>From Murtadha Hubail <[email protected]>:

Attention is currently required from: Hussain Towaileb.

Murtadha Hubail has posted comments on this change by Murtadha Hubail. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20496?usp=email )

Change subject: [NO ISSUE][RT] Respond to NC in case of unexpected failures
......................................................................


Patch Set 2:

(1 comment)

File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20496/comment/d9382156_818383fe?usp=email
 :
PS1, Line 248: messageBroker.sendMessageQuietly(responseMsg, requestNodeId);
> What if the issue in sending was in the content of the response message but 
> not the throwable itself […]
The receiver side needs to at least know the message id. The only thing that we 
don't control in the message is the throwable. However, since we have a similar 
pattern when sending rejection, I refactored that logic and reused it.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: phoenix
Gerrit-Change-Id: I5ff53205d7cbb23c91a482b22165e1645247745f
Gerrit-Change-Number: 20496
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-CC: Hussain Towaileb <[email protected]>
Gerrit-Attention: Hussain Towaileb <[email protected]>
Gerrit-Comment-Date: Fri, 17 Oct 2025 17:23:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hussain Towaileb <[email protected]>

Reply via email to