>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb.
Michael Blow has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485?usp=email ) Change subject: [ASTERIXDB-3657][FAIL]: handle non-serializable exceptions ...................................................................... Patch Set 8: (2 comments) File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/ReplacementsAwareJavaSerializationProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485/comment/7194f82a_34c67ec4?usp=email : PS8, Line 54: // try exact match first (fast path) I would short-circuit synthetics before the lookup and `return super.replaceObject(object)` if so https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485/comment/fc5c544c_d9da9bc2?usp=email : PS8, Line 68: INSTANCE.registerReplacement(object.getClass(), super::replaceObject); I don't love that we're calling `object.getClass()` 3+ times in this method. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I55e69623068a6c1759803cc699417021910237fd Gerrit-Change-Number: 20485 Gerrit-PatchSet: 8 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Thu, 16 Oct 2025 19:04:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
