>From Hussain Towaileb <[email protected]>:
Attention is currently required from: Hussain Towaileb, Michael Blow.
Hello Anon. E. Moose #1000171, Jenkins, Michael Blow,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20463?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by Hussain Towaileb, Code-Review+2 by Michael Blow,
Integration-Tests+1 by Jenkins, Verified+1 by Jenkins, Verified-1 by Anon. E.
Moose #1000171
Change subject: [NO ISSUE]: Refactor AWS common properties
......................................................................
[NO ISSUE]: Refactor AWS common properties
In an anticipation of incoming other AWS clients,
factor out the common AWS properties to a different
class outside of S3-specific classes.
Ext-ref: MB-68835
Change-Id: I4d2a50d361ad949d4d3aeee3208bbd8dbb3e83a2
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalCredentialsCacheUpdater.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RedactionUtil.java
M
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java
M
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/S3ExternalFileWriterFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/AwsS3InputStream.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/delta/AwsS3DeltaReaderFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/parquet/AwsS3ParquetReaderFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java
A
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/AwsConstants.java
A
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/AwsUtils.java
D
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3AuthUtils.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Constants.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java
M
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/awss3/AwsS3Test.java
14 files changed, 657 insertions(+), 623 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/63/20463/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20463?usp=email
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: phoenix
Gerrit-Change-Id: I4d2a50d361ad949d4d3aeee3208bbd8dbb3e83a2
Gerrit-Change-Number: 20463
Gerrit-PatchSet: 4
Gerrit-Owner: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Attention: Hussain Towaileb <[email protected]>
