>From Ritik Raj <[email protected]>:
Attention is currently required from: Ritik Raj.
Hello Anon. E. Moose #1000171, Jenkins, Peeyush Gupta,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20469?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Contrib+1 by Anon. E. Moose #1000171, Integration-Tests+1 by Jenkins,
Verified-1 by Anon. E. Moose #1000171, Verified-1 by Jenkins
Change subject: [ASTERIXDB-3652][STO] Fixed column assembler issues
......................................................................
[ASTERIXDB-3652][STO] Fixed column assembler issues
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
There were few issues related to union + objects + array.
In case of union in objects, introduced a logical barrier,
which in case of missing collects all the missing and only
propogates when it encountered all the children for the
current level, preventing extra null or missing being
propogated above.
There can be cases where a particular column is not presnet,
and the EndOfGroupAssembler uses that column as a delegate,
hence not able to correctly determine the ending of the array
leading to missing of value propogation to parent.
Ext-ref: MB-68881
Change-Id: I782d17f81d00210a4ca8673cc5fbcf556fc4758c
---
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/assembly/ASTERIXDB-3652-1/ASTERIXDB-3652.001.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/assembly/ASTERIXDB-3652-1/ASTERIXDB-3652.002.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/assembly/ASTERIXDB-3652-1/ASTERIXDB-3652.003.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/assembly/ASTERIXDB-3652-2/ASTERIXDB-3652.001.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/assembly/ASTERIXDB-3652-2/ASTERIXDB-3652.002.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/assembly/ASTERIXDB-3652-2/ASTERIXDB-3652.003.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/assembly/ASTERIXDB-3652-3/ASTERIXDB-3652.001.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/assembly/ASTERIXDB-3652-3/ASTERIXDB-3652.002.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/assembly/ASTERIXDB-3652-3/ASTERIXDB-3652.003.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/column/assembly/ASTERIXDB-3652-1/ASTERIXDB-3652.003.adm
A
asterixdb/asterix-app/src/test/resources/runtimets/results/column/assembly/ASTERIXDB-3652-2/ASTERIXDB-3652.003.adm
A
asterixdb/asterix-app/src/test/resources/runtimets/results/column/assembly/ASTERIXDB-3652-3/ASTERIXDB-3652.003.adm
M asterixdb/asterix-app/src/test/resources/runtimets/sqlpp_queries.xml
M
asterixdb/asterix-app/src/test/resources/runtimets/testsuite_single_partition_sqlpp.xml
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/AbstractNestedValueAssembler.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/AbstractPrimitiveValueAssembler.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/ArrayWithUnionValueAssembler.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/AssemblerBuilderVisitor.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/EndOfRepeatedGroupAssembler.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/ObjectValueAssembler.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/PrimitiveValueAssembler.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/RepeatedPrimitiveValueAssembler.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/metadata/schema/ObjectSchemaNode.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/metadata/schema/UnionSchemaNode.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/metadata/schema/collection/AbstractCollectionSchemaNode.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/flush/BatchFinalizerVisitor.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/flush/FlushColumnMetadata.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/IColumnValuesReader.java
M
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/reader/AbstractColumnValuesReader.java
M
asterixdb/asterix-column/src/test/java/org/apache/asterix/column/values/reader/AbstractDummyColumnValuesReader.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/cloud/sweep/ColumnSweepPlanner.java
31 files changed, 634 insertions(+), 77 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/69/20469/8
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20469?usp=email
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: phoenix
Gerrit-Change-Id: I782d17f81d00210a4ca8673cc5fbcf556fc4758c
Gerrit-Change-Number: 20469
Gerrit-PatchSet: 8
Gerrit-Owner: Ritik Raj <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Reviewer: Ritik Raj <[email protected]>
Gerrit-CC: Wail Alkowaileet <[email protected]>
Gerrit-Attention: Ritik Raj <[email protected]>
