>From Ali Alsuliman <[email protected]>: Attention is currently required from: Hussain Towaileb, Murtadha Hubail.
Ali Alsuliman has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20531?usp=email ) Change subject: [NO ISSUE][EXT]: ensure CSV header is written in all files ...................................................................... Patch Set 7: (2 comments) File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/csv/ACSVRecordPrinter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20531/comment/97ef6072_ea53ae53?usp=email : PS7, Line 77: } else { Can we replace the whole thing with: if (!firstRecord) { ps.print(recordDelimiter); } else if (header) { // it's first record and header is true printHeader(recordAccessor, ps, visitor); ps.print(recordDelimiter); } File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/csv/APrintVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20531/comment/f2e16ae3_ed1186a6?usp=email : PS7, Line 89: printer.printRecord(accessor, arg.getFirst(), this, firstRecord); Can we do the following: boolean first = firstRecord; if (firstRecord) { firstRecord = false; } printer.printRecord(accessor, arg.getFirst(), this, first); return null; -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20531?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I7716408908ddb40ec9f26e892da4f7d888751a8b Gerrit-Change-Number: 20531 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Thu, 30 Oct 2025 17:32:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
