>From Ali Alsuliman <[email protected]>: Attention is currently required from: Janhavi Tripurwar, Murtadha Hubail.
Ali Alsuliman has posted comments on this change by Janhavi Tripurwar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441?usp=email ) Change subject: [ASTERIXDB-3665]: Compute RangeMap at Compile time ...................................................................... Patch Set 8: (6 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441/comment/ee804cc8_09951de3?usp=email : PS8, Line 408: physicalRewritesAllLevels.add(new CheckFullParallelSortRule()); We can rename CheckFullParallelSortRule to AttachCompileTimeRangeMapRule and put the logic there instead. File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AttachCompileTimeRangeMapRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441/comment/5f0ec56f_f0ef9146?usp=email : PS8, Line 44: return true; Return true if we changed the plan, false if nothing has changed. File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441/comment/9dabf1ca_90fda2b7?usp=email : PS8, Line 1045: RangeMapUtil.attachStaticRangeMapIfNeeded(rootOrderByOp, optCtx); We don't need this anymore, right? File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/RangeMapUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441/comment/977c9c1a_cd094fe3?usp=email : PS8, Line 200: public static void attachStaticRangeMapIfNeeded(ILogicalOperator rootOrderByOp, IOptimizationContext optCtx) Do we check that we have samples? File asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index/btree-secondary-68_ps.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441/comment/7b6900c7_3c375e9f?usp=email : PS8, Line 49: analyze dataset Orders; We don't need set `compiler.cbo` "true"; File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441/comment/3adb4d0d_596fd178?usp=email : PS8, Line 688: return null; We shouldn't reach here, correct? Maybe throw COMPILATION_ERROR saying no range map found for order by, or something like that -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I51f99463d24596e74b5d435f718236de9016f2e8 Gerrit-Change-Number: 20441 Gerrit-PatchSet: 8 Gerrit-Owner: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-CC: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Janhavi Tripurwar <[email protected]> Gerrit-Comment-Date: Wed, 05 Nov 2025 18:45:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
