>From Ritik Raj <[email protected]>:
Attention is currently required from: Murtadha Hubail, Ritik Raj.
Hello Anon. E. Moose #1000171, Jenkins, Murtadha Hubail,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20565?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Integration-Tests+1 by Jenkins
Change subject: [NO ISSUE][CLOUD] Fix premature buffer release caused by
flatMap cancel
......................................................................
[NO ISSUE][CLOUD] Fix premature buffer release caused by flatMap cancel
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Azure SDK uses Reactor/Netty for async downloads, where each download
is a Mono merged with flatMap. When one Mono fails, flatMap cancels
others, causing Azure to release buffers while Netty may still write
into them, leading to IllegalReferenceCountException. Switching to
flatMapDelayError defers error propagation and prevents premature
cancellation, allowing all downloads to complete safely.
Ext-ref: MB-69283
Change-Id: If0c3577225a0dffffadfab13321a9c8702c3551e
---
M
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/azure/blobstorage/AzureParallelDownloader.java
A
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/azure/blobstorage/ReactiveExponentialRetryPolicy.java
M
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ExponentialRetryPolicy.java
3 files changed, 112 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/65/20565/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20565?usp=email
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: phoenix
Gerrit-Change-Id: If0c3577225a0dffffadfab13321a9c8702c3551e
Gerrit-Change-Number: 20565
Gerrit-PatchSet: 3
Gerrit-Owner: Ritik Raj <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Ritik Raj <[email protected]>