>From Ali Alsuliman <[email protected]>: Attention is currently required from: Shahrzad Shirazi.
Ali Alsuliman has posted comments on this change by Shahrzad Shirazi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20268?usp=email ) Change subject: [ASTERIXDB-3516][COMP] Adding UPDATE statement ...................................................................... Patch Set 51: (4 comments) File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/CheckUpdateSetExpressionsVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20268/comment/27bdddb7_e27a2ad4?usp=email : PS46, Line 48: this.datasetName = updateStatement.getDatasetName(); > Are the changes that I made for this correct now? Yes File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/AbstractSqlppExpressionScopingVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20268/comment/c90bd577_281bc679?usp=email : PS51, Line 387: insertStatement.getQuery().accept(this, insertStatement); I am interested in knowing why this was moved after. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20268/comment/1e680656_1749bcef?usp=email : PS51, Line 457: return rootVarSymbol.substring(0, lastIndexGeneratedVar); Add {} File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecursiveRemovalDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20268/comment/f2abc452_b504819a?usp=email : PS51, Line 37: public class RecursiveRemovalDescriptor extends AbstractScalarFunctionDynamicDescriptor { Rename this to be consistent with the other Record..Descriptor, e.g.: RecordRemoveRecursiveDescriptor -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20268?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ib2d531b7b172b75b9756c7cc9b15dc636641f827 Gerrit-Change-Number: 20268 Gerrit-PatchSet: 51 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Shahrzad Shirazi <[email protected]> Gerrit-Comment-Date: Wed, 03 Dec 2025 02:00:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shahrzad Shirazi <[email protected]> Comment-In-Reply-To: Ali Alsuliman <[email protected]>
