>From Hussain Towaileb <[email protected]>: Attention is currently required from: Peeyush Gupta.
Hussain Towaileb has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20689?usp=email ) Change subject: [ASTERIXDB-3634][EXT]: Add support to Iceberg pt.4 ...................................................................... Patch Set 4: Code-Review+1 (3 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/iceberg/IcebergParquetRecordReaderFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20689/comment/3afc298d_0a0da3cc?usp=email : PS3, Line 206: Map<String, String> configuration, > seems like configurationCopy should be enough here. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20689/comment/0ea9b188_14589943?usp=email : PS3, Line 238: Map<String, String> configuration > I think just passing configurationCopy should work Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20689/comment/eb3f7375_bd53fa75?usp=email : PS3, Line 241: configuration.remove(ICEBERG_SNAPSHOT_TIMESTAMP_PROPERTY_KEY); : configurationCopy.remove(ICEBERG_SNAPSHOT_TIMESTAMP_PROPERTY_KEY); : > These remove calls are not required Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20689?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0d9d962720e3a8fb4935d35ec3efa50c5ffc030a Gerrit-Change-Number: 20689 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Tue, 23 Dec 2025 05:54:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Peeyush Gupta <[email protected]>
