Michael Blow has posted comments on this change. Change subject: Unify structure of Cluster Controller and Node Controller ......................................................................
Patch Set 8: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1514/8/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java: PS8, Line 204: if (!configured) { : conf = confFactory.getConf(); : inputSplits = inputSplitsFactory.getSplits(); : nodeName = ctx.getJobletContext().getServiceContext().getNodeId(); : configured = true; : } extract into separate method and eliminate duplicate blocks? https://asterix-gerrit.ics.uci.edu/#/c/1514/8/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/IControllerService.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/IControllerService.java: PS8, Line 24: //NOSONAR I don't think these should be suppressed- it's something we might want to fix someday, right? https://asterix-gerrit.ics.uci.edu/#/c/1514/8/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/test/support/TestUtils.java File hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/test/support/TestUtils.java: Line 66: BufferedReader readerActual = new BufferedReader(new FileReader(actualFile)); > BLOCKER SonarQube violation: good point Line 72: // Assert.assertEquals(lineExpected, lineActual); > MAJOR SonarQube violation: good point -- To view, visit https://asterix-gerrit.ics.uci.edu/1514 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife3a002371a07ee9cdd32e1ffd50cc775bf1d453 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
