>From Janhavi Tripurwar <[email protected]>:

Attention is currently required from: Ali Alsuliman, Ali Alsuliman, Murtadha 
Hubail.

Janhavi Tripurwar has posted comments on this change by Janhavi Tripurwar. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20035?usp=email )

Change subject: [NO ISSUE][RT]: Refactor: Remove code duplication in stable 
sort operators
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SortOperatorHelper.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20035/comment/548be700_5fceec9d?usp=email
 :
PS2, Line 38: public class SortOperatorHelper {
> Move the code to AbstractStableSortPOperator and make things protected 
> instead of being public since […]
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20035?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I2a0fc093d356be7e2379a66c6843ebd6b6cdbd4c
Gerrit-Change-Number: 20035
Gerrit-PatchSet: 4
Gerrit-Owner: Janhavi Tripurwar <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Janhavi Tripurwar <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-CC: Ali Alsuliman <[email protected]>
Gerrit-CC: Michael Blow <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Comment-Date: Wed, 14 Jan 2026 16:21:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ali Alsuliman <[email protected]>

Reply via email to