>From Peeyush Gupta <[email protected]>:

Attention is currently required from: Shahrzad Shirazi.

Peeyush Gupta has posted comments on this change by Shahrzad Shirazi. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774?usp=email )

Change subject: [ASTERIXDB-3688][COMP] Improving Index Selection for Index-Only 
Query Plans
......................................................................


Patch Set 11:

(1 comment)

File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774/comment/f4a4f2b9_7f6f8e3f?usp=email
 :
PS11, Line 425:  if (coversAllI && !coversAllJ) {
              :                                             // Smaller prefix 
covers all, keep it, remove larger
              :                                             include[j] = false;
I am not sure if this resolves Ali's earlier point. For example consider a 
query on collection1

    SELECT c from collection1 where a=1 and b=2
consider two indexes
`(a, b)` non covering
`(a, c, b)` covering

Which index should be picked in the following 2 scenarios
1. collection1 has 100 other fields
2. collection1 has only 1 other fields
3. We do not know how many fields are in collection1



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I4f996ee7b6eb03067fb384161fb4eb60f94e8353
Gerrit-Change-Number: 20774
Gerrit-PatchSet: 11
Gerrit-Owner: Shahrzad Shirazi <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Reviewer: Preetham Poluparthi <[email protected]>
Gerrit-Attention: Shahrzad Shirazi <[email protected]>
Gerrit-Comment-Date: Mon, 19 Jan 2026 18:27:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to