>From Ali Alsuliman <[email protected]>:

Attention is currently required from: Michael Blow, Murtadha Hubail, Peeyush 
Gupta, Preetham Poluparthi.

Ali Alsuliman has posted comments on this change by Ali Alsuliman. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20801?usp=email )

Change subject: [ASTERIXDB-3692][COMP] Allow setting frame size at query level
......................................................................


Patch Set 2:

(1 comment)

File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/OptimizationConfUtil.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20801/comment/a3a39278_7822c1e6?usp=email
 :
PS2, Line 54:         int frameSize = compilerProperties.getFrameSize();
> Are other usages of getFrameSize() taken care? For example, there is one in 
> NCAppRuntimeContext.
This patch is to only handle query processing. Those places are different (the 
example you gave is for ingestion). Changing the frame size at cluster level 
without requiring a restart is beyond this change.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20801?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Icf52985cd22eed8ae93439d1faa187ce23d31630
Gerrit-Change-Number: 20801
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Reviewer: Preetham Poluparthi <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Peeyush Gupta <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Attention: Preetham Poluparthi <[email protected]>
Gerrit-Comment-Date: Tue, 20 Jan 2026 16:07:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Preetham Poluparthi <[email protected]>

Reply via email to