>From Wail Alkowaileet <[email protected]>:

Attention is currently required from: Ritik Raj.

Wail Alkowaileet has posted comments on this change by Ritik Raj. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20834?usp=email )

Change subject: [ASTERIXDB-3694][STO] Parquet reader INTERVAL support
......................................................................


Patch Set 2:

(1 comment)

File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/parquet/ParquetValueWriter.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20834/comment/6d58c705_1dc6416f?usp=email
 :
PS1, Line 215:             intervalBytes[0] = (byte) (months);
             :                 intervalBytes[1] = (byte) (months >>> 8);
             :                 intervalBytes[2] = (byte) (months >>> 16);
             :                 intervalBytes[3] = (byte) (months >>> 24);
             :                 intervalBytes[4] = (byte) (days);
             :                 intervalBytes[5] = (byte) (days >>> 8);
             :                 intervalBytes[6] = (byte) (days >>> 16);
             :                 intervalBytes[7] = (byte) (days >>> 24);
             :                 intervalBytes[8] = (byte) (millisOfDay);
             :                 intervalBytes[9] = (byte) (millisOfDay >>> 8);
             :                 intervalBytes[10] = (byte) (millisOfDay >>> 16);
             :                 intervalBytes[11] = (byte) (millisOfDay >>> 24);
> Parquet do have a way to write Little Endian, but seems a bit of work, they 
> all need an output strea […]
I would use it! Just make sure that byte[] is allocated once and it is within 
the class. The size of byte[] cannot be changed - thus, it is only used for 
fixed-length values. reset() should not take any parameters but to set pos to 0.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20834?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I8dcd0da5db34991280bc4655059ca418fd8a71c9
Gerrit-Change-Number: 20834
Gerrit-PatchSet: 2
Gerrit-Owner: Ritik Raj <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Ritik Raj <[email protected]>
Gerrit-CC: Wail Alkowaileet <[email protected]>
Gerrit-Attention: Ritik Raj <[email protected]>
Gerrit-Comment-Date: Thu, 22 Jan 2026 10:09:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wail Alkowaileet <[email protected]>
Comment-In-Reply-To: Ritik Raj <[email protected]>

Reply via email to