>From Peeyush Gupta <[email protected]>:

Peeyush Gupta has submitted this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/20843?usp=email )

Change subject: [NO ISSUE][TACO] Add option for other auth types
......................................................................

[NO ISSUE][TACO] Add option for other auth types

Change-Id: I15e37f2a443747b42ee17058fe5baa9f49e05565
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/20843
Tested-by: Jenkins <[email protected]>
Reviewed-by: Ian Maxon <[email protected]>
---
M asterixdb-jdbc/asterix-jdbc-taco/pom.xml
M 
asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
2 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins: Verified
  Ian Maxon: Looks good to me, approved




diff --git a/asterixdb-jdbc/asterix-jdbc-taco/pom.xml 
b/asterixdb-jdbc/asterix-jdbc-taco/pom.xml
index 12de8a4..1c4e4ee 100644
--- a/asterixdb-jdbc/asterix-jdbc-taco/pom.xml
+++ b/asterixdb-jdbc/asterix-jdbc-taco/pom.xml
@@ -53,6 +53,8 @@
     <taco.plugin.table.label>Dataset</taco.plugin.table.label>
     <taco.plugin.jdbc.scheme>jdbc:asterixdb://</taco.plugin.jdbc.scheme>
     <taco.plugin.auth.none><![CDATA[<option value="auth-none" label="No 
Authentication"/>]]></taco.plugin.auth.none>
+    <taco.plugin.auth.other/>
+    <taco.plugin.auth.userpass.condition/>
     <taco.plugin.fields.custom/>
     <taco.plugin.norm.attributes.custom/>
     <taco.plugin.jdbc.properties.custom/>
diff --git 
a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
 
b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
index dde677d..3a8508e 100644
--- 
a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
+++ 
b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/connection-fields.xml
@@ -26,17 +26,20 @@
     <selection-group>
       ${taco.plugin.auth.none}
       <option value="auth-user-pass" label="Username and Password"/>
+      ${taco.plugin.auth.other}
     </selection-group>
   </field>

   <field name="username" label="Username" category="authentication" 
value-type="string">
     <conditions>
+      ${taco.plugin.auth.userpass.condition}
       <condition field="authentication" value="auth-user-pass"/>
     </conditions>
   </field>

   <field name="password" label="Password" category="authentication" 
value-type="string" secure="true">
     <conditions>
+      ${taco.plugin.auth.userpass.condition}
       <condition field="authentication" value="auth-user-pass"/>
     </conditions>
   </field>

--
To view, visit 
https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/20843?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: asterixdb-clients
Gerrit-Branch: master
Gerrit-Change-Id: I15e37f2a443747b42ee17058fe5baa9f49e05565
Gerrit-Change-Number: 20843
Gerrit-PatchSet: 2
Gerrit-Owner: Peeyush Gupta <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>

Reply via email to