>From Ian Maxon <[email protected]>: Attention is currently required from: Peeyush Gupta.
Ian Maxon has posted comments on this change by Peeyush Gupta. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20802?usp=email ) Change subject: [ASTERIXDB-3693][API] Add request level result_ttl ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: check the new tests as well in NCServiceExecutionIT- seems like one of them is failing somehow File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/ResultProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20802/comment/7e1fbfb1_fea7d85f?usp=email : PS4, Line 54: public long getResultTtlInMillis() { : return resultTtlInMillis; : } is it possible to return the default here directly rather than having the caller check if it returns DEFAULT_RESULT_TTL? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20802?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Idb5597cf401490d4d074580135cdd37674b036a2 Gerrit-Change-Number: 20802 Gerrit-PatchSet: 4 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Tue, 27 Jan 2026 22:07:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
