>From Ali Alsuliman <[email protected]>: Attention is currently required from: Shahrzad Shirazi.
Ali Alsuliman has posted comments on this change by Shahrzad Shirazi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774?usp=email ) Change subject: [ASTERIXDB-3688][COMP] Improving Index Selection for Index-Only Query Plans ...................................................................... Patch Set 20: (8 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774/comment/5c43e4cb_c26dd92d?usp=email : PS20, Line 389: ArrayList Use List<> as we do normally https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774/comment/6b2f68c8_548fe4ea?usp=email : PS20, Line 569: ArrayList Be consistent and continue to use List<> instead of ArrayList<> https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774/comment/842b3198_01b097aa?usp=email : PS20, Line 581: fillFieldNamesInTheSubTree(subTree, context); Do we need to re-calculate this for each index? It seems it should be enough to do that only once. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774/comment/73000d95_d77491dd?usp=email : PS20, Line 594: subTree.getVarsToFieldNameMap().clear(); Maybe clear below inside the places where index-only shouldn't be triggered? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774/comment/404b8d40_50eb5b6f?usp=email : PS20, Line 616: fillFieldNamesInTheSubTree(subTree, context); Maybe remove if already calculated above? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774/comment/2e76ff7f_9fa1d3cd?usp=email : PS20, Line 627: fillFieldNamesInTheSubTree(subTree, context); Same. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774/comment/95f3d81e_81813f8f?usp=email : PS20, Line 632: res = intersectAllSecondaryIndexes(nonCoverigIndexes, analyzedAMs, context); Clear https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774/comment/0e1a4da7_1a28b830?usp=email : PS20, Line 674: Find earliest equality position Maybe calculate max leading EQs? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I4f996ee7b6eb03067fb384161fb4eb60f94e8353 Gerrit-Change-Number: 20774 Gerrit-PatchSet: 20 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Preetham Poluparthi <[email protected]> Gerrit-Attention: Shahrzad Shirazi <[email protected]> Gerrit-Comment-Date: Wed, 04 Feb 2026 23:14:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
