>From Hussain Towaileb <[email protected]>:

Hussain Towaileb has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20889?usp=email )


Change subject: [NO ISSUE][EXT]: avoid closing resources on non-initialized 
tasks
......................................................................

[NO ISSUE][EXT]: avoid closing resources on non-initialized tasks

Ext-ref: MB-70518
Change-Id: Ide795ea6b0cebf2415a38f09090440ba3792d6c1
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergUtils.java
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/20889/1

diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergUtils.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergUtils.java
index 20ce57b..9a7c97d 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergUtils.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergUtils.java
@@ -348,8 +348,10 @@
         } catch (Exception ex) {
             throw CompilationException.create(ErrorCode.EXTERNAL_SOURCE_ERROR, 
ex, ex.getMessage());
         } finally {
-            String awsClientsFactoryId = 
catalogProperties.get(FACTORY_INSTANCE_ID_KEY);
-            EnsureCloseClientsFactoryRegistry.closeAll(awsClientsFactoryId);
+            if (catalog != null) {
+                String awsClientsFactoryId = 
catalogProperties.get(FACTORY_INSTANCE_ID_KEY);
+                
EnsureCloseClientsFactoryRegistry.closeAll(awsClientsFactoryId);
+            }:
         }
     }


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20889?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ide795ea6b0cebf2415a38f09090440ba3792d6c1
Gerrit-Change-Number: 20889
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <[email protected]>

Reply via email to