From Ian Maxon <[email protected]>: Attention is currently required from: Suryaa Charan Shivakumar.
Ian Maxon has posted comments on this change by Suryaa Charan Shivakumar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20904?usp=email ) Change subject: [ASTERIXDB][GEO] Add new geospatial functions ...................................................................... Patch Set 1: (3 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20904/comment/24a9227c_f4c320c2?usp=email : PS1, Line 7: [ASTERIXDB should reference an issue File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STFlipCoordinatesDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20904/comment/34d02114_b0c45fb5?usp=email : PS1, Line 37: new CoordinateSequenceFilter() { : @Override : public void filter(CoordinateSequence seq, int i) { : double x = seq.getX(i); : double y = seq.getY(i); : seq.setOrdinate(i, CoordinateSequence.X, y); : seq.setOrdinate(i, CoordinateSequence.Y, x); : } : : @Override : public boolean isDone() { : return false; : } : : @Override : public boolean isGeometryChanged() { : return true; : } : }); just have this as a nested class or something and initialize it as static instead of calling new here File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STSetSRIDDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20904/comment/43b0f3c8_4d6cee84?usp=email : PS1, Line 39: geometry.setSRID(n); what does this do when we don't have full crs support? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20904?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ic4791ce4934ff3a1dd9051ddb13846a4bea4e5c1 Gerrit-Change-Number: 20904 Gerrit-PatchSet: 1 Gerrit-Owner: Suryaa Charan Shivakumar <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Suryaa Charan Shivakumar <[email protected]> Gerrit-Comment-Date: Tue, 17 Feb 2026 18:54:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
