From Suryaa Charan Shivakumar <[email protected]>: Attention is currently required from: Ian Maxon.
Suryaa Charan Shivakumar has posted comments on this change by Suryaa Charan Shivakumar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20904?usp=email ) Change subject: [ASTERIXDB-3705][GEO] Add new geospatial functions ...................................................................... Patch Set 3: (4 comments) Patchset: PS3: Thank you for the review, updated with a new patchiest after resolving Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20904/comment/cb5fe89b_d5b0ef59?usp=email : PS1, Line 7: [ASTERIXDB > should reference an issue Done File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STFlipCoordinatesDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20904/comment/474ad8c3_803e3ddd?usp=email : PS1, Line 37: new CoordinateSequenceFilter() { : @Override : public void filter(CoordinateSequence seq, int i) { : double x = seq.getX(i); : double y = seq.getY(i); : seq.setOrdinate(i, CoordinateSequence.X, y); : seq.setOrdinate(i, CoordinateSequence.Y, x); : } : : @Override : public boolean isDone() { : return false; : } : : @Override : public boolean isGeometryChanged() { : return true; : } : }); > just have this as a nested class or something and initialize it as static > instead of calling new her […] Done File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STSetSRIDDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20904/comment/38c53e27_7dae1f97?usp=email : PS1, Line 39: geometry.setSRID(n); > what does this do when we don't have full crs support? Removed -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20904?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ic4791ce4934ff3a1dd9051ddb13846a4bea4e5c1 Gerrit-Change-Number: 20904 Gerrit-PatchSet: 3 Gerrit-Owner: Suryaa Charan Shivakumar <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Tue, 17 Feb 2026 20:48:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]>
