From Hussain Towaileb <[email protected]>: Hussain Towaileb has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20889?usp=email )
Change subject: [NO ISSUE][EXT]: avoid closing resources on non-initialized tasks ...................................................................... [NO ISSUE][EXT]: avoid closing resources on non-initialized tasks Ext-ref: MB-70518 Change-Id: Ide795ea6b0cebf2415a38f09090440ba3792d6c1 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20889 Reviewed-by: Hussain Towaileb <[email protected]> Reviewed-by: Ali Alsuliman <[email protected]> Integration-Tests: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> --- M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergUtils.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Ali Alsuliman: Looks good to me, approved Jenkins: Verified; Verified Hussain Towaileb: Looks good to me, but someone else must approve Objections: Anon. E. Moose #1000171: Violations found diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergUtils.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergUtils.java index 20ce57b..c9a4e5b 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergUtils.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergUtils.java @@ -348,8 +348,10 @@ } catch (Exception ex) { throw CompilationException.create(ErrorCode.EXTERNAL_SOURCE_ERROR, ex, ex.getMessage()); } finally { - String awsClientsFactoryId = catalogProperties.get(FACTORY_INSTANCE_ID_KEY); - EnsureCloseClientsFactoryRegistry.closeAll(awsClientsFactoryId); + if (catalogProperties != null) { + String awsClientsFactoryId = catalogProperties.get(FACTORY_INSTANCE_ID_KEY); + EnsureCloseClientsFactoryRegistry.closeAll(awsClientsFactoryId); + } } } -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20889?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ide795ea6b0cebf2415a38f09090440ba3792d6c1 Gerrit-Change-Number: 20889 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]>
