From Ali Alsuliman <[email protected]>: Attention is currently required from: Hussain Towaileb, Michael Blow, Murtadha Hubail.
Ali Alsuliman has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20886?usp=email ) Change subject: [NO ISSUE][EXT]: Validate snapshot on creation and query ...................................................................... Patch Set 2: (2 comments) File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20886/comment/5af8f744_06070617?usp=email : PS1, Line 353: 1243 = Snapshot '%1$s' not found for table '%2$s'. ``` 1238 = Iceberg snapshot '%1$s' not found 1243 = Snapshot '%1$s' not found for table '%2$s'. ``` What is the difference? File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergSnapshotUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20886/comment/d8142461_7aed0fb1?usp=email : PS2, Line 108: validateSnapshotExists(icebergCatalog, tableIdentifier, optional.get()); Can't you call `snapshotIdExists()` directly instead of `validateSnapshotExists()` to avoid doing `loadTable()` again, or? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20886?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ib8bb436d966a5b801f677922c3809065167f7f87 Gerrit-Change-Number: 20886 Gerrit-PatchSet: 2 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Wed, 18 Feb 2026 16:00:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
