>From Ali Alsuliman <[email protected]>: Attention is currently required from: Calvin Thomas Dani, Ian Maxon.
Ali Alsuliman has posted comments on this change by Calvin Thomas Dani. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126?usp=email ) Change subject: [ASTERIXDB-3676] Vector Distance KNN Function ...................................................................... Patch Set 19: (1 comment) File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/6fe4a3ec_6d4a2a6c?usp=email : PS19, Line 1892: INSTANCE You should use INSTANCE_NULLABLE if your functions return 'null'. You can use INSTANCE if your functions return MISSING/NULL only as a result of the arguments being MISSING/NULL. I do see that the functions can return NULL for cases other than just the arguments being NULL. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I45176e7da13ed222f48bb36bd1f0ab4074a0bcb9 Gerrit-Change-Number: 20126 Gerrit-PatchSet: 19 Gerrit-Owner: Calvin Thomas Dani <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Calvin Thomas Dani <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Thu, 19 Feb 2026 12:33:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
