>From Hussain Towaileb <[email protected]>: Attention is currently required from: Ali Alsuliman, Michael Blow, Murtadha Hubail.
Hussain Towaileb has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20886?usp=email ) Change subject: [ASTERIXDB-3634][EXT]: Validate snapshot on creation and query ...................................................................... Patch Set 3: Code-Review+1 (3 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20886/comment/75790be5_c1da112b?usp=email : PS2, Line 7: NO ISSUE > You can keep re-using the ASTERIXDB JIRA issue for the improvement instead of > [NO ISSUE]. Done File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20886/comment/7541724e_09c4c8a0?usp=email : PS1, Line 353: 1243 = Snapshot '%1$s' not found for table '%2$s'. > ``` […] Fixed, just didn't noticed I had that one. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergSnapshotUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20886/comment/623adda9_ebf7145d?usp=email : PS2, Line 108: validateSnapshotExists(icebergCatalog, tableIdentifier, optional.get()); > Can't you call `snapshotIdExists()` directly instead of > `validateSnapshotExists()` to avoid doing ` […] Good catch, done. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20886?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ib8bb436d966a5b801f677922c3809065167f7f87 Gerrit-Change-Number: 20886 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Fri, 20 Feb 2026 03:29:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]>
