>From Ian Maxon <[email protected]>: Attention is currently required from: Peeyush Gupta, Ritik Raj.
Ian Maxon has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20984?usp=email ) Change subject: [ASTERIXDB-3715][RT] Upgrade UTF8StringPointable string search to KMP ...................................................................... Patch Set 2: Code-Review+2 (3 comments) File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringPointable.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20984/comment/e546c050_26b6201d?usp=email : PS1, Line 309: computeLPS > Ah, true, pi is very common terminology; I didn’t know that earlier. […] oic, either way is fine, as long as something authoritative mentions it. i wanted to be sure it wasn't something gemini invented somehow https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20984/comment/9afe5767_22c8017e?usp=email : PS1, Line 315: if (patternChars[i] == patternChars[len]) { > true, but ig we won't ever be matching if pattern does not have a valid > surrogate pair... yeah we'll just fail later then i suppose. seems fine then. the surrogate pair handling snippet is annoying https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20984/comment/860f929f_ceb3a4af?usp=email : PS1, Line 382: if (Character.isHighSurrogate(ch1)) { : prevHigh = true; : } else if (Character.isLowSurrogate(ch1)) { : if (prevHigh) { : codePointCount++; : prevHigh = false; : } else { : throw HyracksDataException.create(INVALID_STRING_UNICODE, : LOW_SURROGATE_WITHOUT_HIGH_SURROGATE); : } : } else { : codePointCount++; : } > yeah, I thought to extract it out, but felt not much readable. mmm yeah perhaps you're right. since you have to bring two variables with you that are local to the method. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20984?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: Ia00fbce6499a5258127c91d3ce62270722b89112 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 2 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-CC: Anon. E. Moose #1000171 Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Thu, 12 Mar 2026 18:12:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Ritik Raj <[email protected]>
