Yingyi Bu has posted comments on this change. Change subject: Fix transaction logs and optimize upserts ......................................................................
Patch Set 7: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1554/7/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java: PS7, Line 697: forceUpsert This does not seem entirely right to me... If you do forceUpsert(...), you create a new log entry (undone_v, old_v). Then, if you hit a failure later and do recovery again, you recovered to undone_v, which shouldn't be there at all because it is undone. Did I miss anything? https://asterix-gerrit.ics.uci.edu/#/c/1554/7/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputOneOutputPushRuntime.java File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/base/AbstractOneInputOneOutputPushRuntime.java: PS7, Line 32: RecordDescriptor It looks that this method is unused? -- To view, visit https://asterix-gerrit.ics.uci.edu/1554 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice5296267033cd7debe76894c864c6411f761d83 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
