>From Michael Blow <[email protected]>: Michael Blow has uploaded a new patch set (#2). ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21186?usp=email )
Change subject: [NO ISSUE][HYR][MISC] Fix Span lifefycle / API issues ...................................................................... [NO ISSUE][HYR][MISC] Fix Span lifefycle / API issues - Fix elapsed() to use >= instead of >, which caused spans to require spanNanos + 1ns before reporting as elapsed (off-by-one bug) - Introduce startElapsed() which initializes startNanos so the span is immediately elapsed. startElapsed() is analogous to a do/while loop: elapsed on first check, then reset() begins the countdown; start() is while/do - Make ELAPSED an immutable sentinel (like INFINITE) with reset() as no-op, preventing accidental mutation of the shared constant - Use Span.start() (not startElapsed()) for genuine countdowns where pre-expiry would be dangerous Ext-ref: MB-71012 Change-Id: I34f8fcf03329ea292c6b2637274c1c1c7c4f1462 --- M hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/Span.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/annotations/AiProvenance.java A hyracks-fullstack/hyracks/hyracks-util/src/test/java/org/apache/hyracks/util/SpanTest.java 3 files changed, 618 insertions(+), 5 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/86/21186/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21186?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I34f8fcf03329ea292c6b2637274c1c1c7c4f1462 Gerrit-Change-Number: 21186 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Blow <[email protected]> Gerrit-CC: Anon. E. Moose #1000171 Gerrit-CC: Jenkins <[email protected]>
