Michael Blow has posted comments on this change. Change subject: Deferred result delivery improvements ......................................................................
Patch Set 17: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1548/17/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java: PS17, Line 181: sb.append("{ "); : sb.append("\"host\": \"").append(host).append("\", "); : sb.append("\"path\": \"").append(path).append("\", "); : sb.append("\"statement\": \""); : JSONUtil.escape(sb, statement); : sb.append("\", "); : sb.append("\"format\": \"").append(format).append("\", "); : sb.append("\"pretty\": ").append(pretty).append(", "); : sb.append("\"mode\": ").append(mode).append(", "); : sb.append("\"clientContextID\": \"").append(clientContextID).append("\" "); : sb.append('}'); Should we use some JSON serializer to do this? https://asterix-gerrit.ics.uci.edu/#/c/1548/17/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java: PS17, Line 333: sb.append("{ "); : sb.append('"').append("rspid").append("\":\"").append(resultSetPartitionId).append("\", "); : sb.append('"').append("async").append("\":").append(asyncMode).append(", "); : sb.append('"').append("eos").append("\":").append(eos).append(", "); : sb.append('"').append("failed").append("\":").append(failed).append(", "); : sb.append('"').append("fileRef").append("\":\"").append(String.valueOf(fileRef)).append("\" }"); : return sb.toString(); it does seem like we need some facility to construct JSON strings to avoid the " : { business all over... but not a blocker -- To view, visit https://asterix-gerrit.ics.uci.edu/1548 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88fe289fe9109ea012c63d82af0083dce6bde31b Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
