>From Michael Blow <[email protected]>: Attention is currently required from: Ritik Raj.
Michael Blow has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21198?usp=email ) Change subject: [ASTERIXDB-3768][CLOUD] Add configurable S3 checksum behavior for S3-compatible storage ...................................................................... Patch Set 8: (1 comment) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21198/comment/689bc947_304824fb?usp=email : PS8, Line 198: ICloudProperties cloudProperties = appCtx.getCloudProperties(); : S3ChecksumBehavior checksumBehavior; : if (cloudProperties != null) { : checksumBehavior = cloudProperties.getS3ChecksumBehavior(); : } else { : // No cloud properties (external data context): default based on whether a custom endpoint is in use : checksumBehavior = S3ChecksumBehavior.defaultForEndpoint(serviceEndpoint); : } : applyChecksumBehavior(builder, checksumBehavior); presumably this is getting replaced in the forthcoming patch- it is not right to consider cloud properties here at all, as this is always external link context. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21198?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: If6618d3a336e9bf134efb1f219660421edc27c43 Gerrit-Change-Number: 21198 Gerrit-PatchSet: 8 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Mon, 11 May 2026 10:56:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
