>From Ritik Raj <[email protected]>: Ritik Raj has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21177?usp=email )
Change subject: [NO ISSUE][EXT] loosening ser/de visibility ...................................................................... [NO ISSUE][EXT] loosening ser/de visibility Ext-ref: MB-70982 Change-Id: Id81fa96c28b2739f3b94d357ad4f327469700a75 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21177 Integration-Tests: Jenkins <[email protected]> Reviewed-by: Michael Blow <[email protected]> Tested-by: Jenkins <[email protected]> Tested-by: Michael Blow <[email protected]> --- M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/StandardUTF8ToModifiedUTF8OutputStream.java 2 files changed, 17 insertions(+), 9 deletions(-) Approvals: Jenkins: Verified; Verified Michael Blow: Looks good to me, approved; Verified diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java index de889a2..0f59e46 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMetadataAndPK.java @@ -61,17 +61,17 @@ SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.ADOUBLE); private final AMutableDouble mutableDouble = new AMutableDouble(0); @SuppressWarnings("unchecked") - private final ISerializerDeserializer<AString> stringSerde = + protected final ISerializerDeserializer<AString> stringSerde = SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.ASTRING); - private final AMutableString mutableString = new AMutableString(null); + protected final AMutableString mutableString = new AMutableString(null); @SuppressWarnings("unchecked") - private final ISerializerDeserializer<AInt32> int32Serde = + protected final ISerializerDeserializer<AInt32> int32Serde = SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.AINT32); - private final AMutableInt32 mutableInt = new AMutableInt32(0); + protected final AMutableInt32 mutableInt = new AMutableInt32(0); @SuppressWarnings("unchecked") protected ISerializerDeserializer<AInt64> int64Serde = SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.AINT64); - private final AMutableInt64 mutableLong = new AMutableInt64(0); + protected final AMutableInt64 mutableLong = new AMutableInt64(0); @SuppressWarnings("unchecked") private final ISerializerDeserializer<ABoolean> booleanSerde = SerializerDeserializerProvider.INSTANCE.getSerializerDeserializer(BuiltinType.ABOOLEAN); diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/StandardUTF8ToModifiedUTF8OutputStream.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/StandardUTF8ToModifiedUTF8OutputStream.java index 035ee68..fc77469 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/StandardUTF8ToModifiedUTF8OutputStream.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/StandardUTF8ToModifiedUTF8OutputStream.java @@ -39,10 +39,14 @@ private DataOutput out; public StandardUTF8ToModifiedUTF8OutputStream(AStringSerializerDeserializer stringSerDer) { + this(stringSerDer, ExternalDataConstants.DEFAULT_BUFFER_SIZE); + } + + public StandardUTF8ToModifiedUTF8OutputStream(AStringSerializerDeserializer stringSerDer, int bufferSize) { this.stringSerDer = stringSerDer; - reader = new ResettableUTF8InputStreamReader(new ByteArrayAccessibleInputStream(EMPTY, 0, 0)); - inputBuffer = new char[ExternalDataConstants.DEFAULT_BUFFER_SIZE]; - appendBuffer = new char[ExternalDataConstants.DEFAULT_BUFFER_SIZE]; + reader = new ResettableUTF8InputStreamReader(new ByteArrayAccessibleInputStream(EMPTY, 0, 0), bufferSize); + inputBuffer = new char[bufferSize]; + appendBuffer = new char[bufferSize]; } @Override @@ -87,7 +91,11 @@ private final ByteArrayAccessibleInputStream inByte; public ResettableUTF8InputStreamReader(ByteArrayAccessibleInputStream inByte) { - super(new BasicInputStream(inByte), ExternalDataConstants.DEFAULT_BUFFER_SIZE); + this(inByte, ExternalDataConstants.DEFAULT_BUFFER_SIZE); + } + + public ResettableUTF8InputStreamReader(ByteArrayAccessibleInputStream inByte, int bufferSize) { + super(new BasicInputStream(inByte), bufferSize); this.inByte = inByte; } -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21177?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: Id81fa96c28b2739f3b94d357ad4f327469700a75 Gerrit-Change-Number: 21177 Gerrit-PatchSet: 5 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]>
