>From Ian Maxon <[email protected]>: Attention is currently required from: Suryaa Charan Shivakumar.
Ian Maxon has posted comments on this change by Suryaa Charan Shivakumar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237?usp=email ) Change subject: [WIP][ASTERIXDB-3776] Add OGC/PostGIS compatibility layer for geospatial functions ...................................................................... Patch Set 2: (6 comments) File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STCollectionExtractDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237/comment/329871f7_95b483b8?usp=email : PS2, Line 35: PostGIS ST_CollectionExtract: extracts components of the requested type from : * a geometry collection, returning them as a homogeneous geometry. Type codes : * follow PostGIS unless PostGIS is the only implementation of this function let's not refer to it File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STGeometryNOGCDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237/comment/abfefc15_e1e85ce7?usp=email : PS2, Line 28: PostGIS-conformant same here File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STGeometryTypeOGCDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237/comment/694138c6_411b0fbc?usp=email : PS2, Line 28: PostGIS-conformant here too File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STLineMergeDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237/comment/7a42cc2d_e75e8706?usp=email : PS2, Line 47: LineMerger merger = new LineMerger(); no way to reuse objects here? File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STNumPointsOGCDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237/comment/7dcb62d4_00eb186b?usp=email : PS2, Line 41: if (!(geometry instanceof LineString)) { : return null; : } : return ((LineString) geometry).getNumPoints(); this is a method of Geometry isn't it? can't you just use getGeometryType to guard here instead of instanceof as well, if you aren't casting? File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STPointNOGCDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237/comment/f3cf66c3_7b3573e4?usp=email : PS2, Line 51: LineString line = (LineString) geometry; : if (n < 1 || n > line.getNumPoints()) { same here -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia6e37080a581292744ddc9020b814927413c16ac Gerrit-Change-Number: 21237 Gerrit-PatchSet: 2 Gerrit-Owner: Suryaa Charan Shivakumar <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Suryaa Charan Shivakumar <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2026 23:06:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
