>From Ian Maxon <[email protected]>: Attention is currently required from: Suryaa Charan Shivakumar.
Ian Maxon has posted comments on this change by Suryaa Charan Shivakumar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237?usp=email ) Change subject: [ASTERIXDB-3776] Add OGC/PostGIS compatibility layer for geospatial functions ...................................................................... Patch Set 3: (3 comments) File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STLineMergeDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237/comment/f1a25628_aa94543b?usp=email : PS2, Line 47: LineMerger merger = new LineMerger(); > I did check try this, as some of our previous work had related comments. […] Acknowledged File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STNumPointsOGCDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237/comment/66ed5aac_d1907ee9?usp=email : PS2, Line 41: if (!(geometry instanceof LineString)) { : return null; : } : return ((LineString) geometry).getNumPoints(); > In this case and a few others we maybe prone to subclass-blindness, so I felt > this is a better way t […] Acknowledged File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STPointNOGCDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237/comment/f16df04a_374360c9?usp=email : PS2, Line 51: LineString line = (LineString) geometry; : if (n < 1 || n > line.getNumPoints()) { > line. […] ah, that's too bad. some of the object hierarchy decisions here from JTS leaves something to be desired imo -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21237?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia6e37080a581292744ddc9020b814927413c16ac Gerrit-Change-Number: 21237 Gerrit-PatchSet: 3 Gerrit-Owner: Suryaa Charan Shivakumar <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Suryaa Charan Shivakumar <[email protected]> Gerrit-Comment-Date: Fri, 22 May 2026 16:43:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Suryaa Charan Shivakumar <[email protected]>
