>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Altowileb, Preetham Poluparthi.
Michael Blow has posted comments on this change by Preetham Poluparthi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277?usp=email ) Change subject: [ASTERIXDB-3768][CLOUD] Add S3 legacy MD5 and disable chunked encoding knobs ...................................................................... Patch Set 6: (4 comments) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/25563c24_eff3b7ce?usp=email : PS6, Line 114: String endpoint = app.getString(CLOUD_STORAGE_ENDPOINT); : return endpoint != null && !endpoint.isEmpty(); I think we should default this to false. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/e457d865_3dd01812?usp=email : PS6, Line 274: + " Defaults to true when a custom endpoint is configured, false for native AWS S3."; I think we should default this to false. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/5e26feb3_88dd956b?usp=email : PS6, Line 298: || this == CLOUD_STORAGE_S3_DISABLE_CHUNKED_ENCODING ```suggestion if (this == CLOUD_STORAGE_S3_LEGACY_MD5_CHECKSUM) { ``` File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/3c952ed3_6b39dabb?usp=email : PS6, Line 211: builder.serviceConfiguration(S3Configuration.builder().chunkedEncodingEnabled(false).build()); We don't want to set chunked encoding implicitly. There's probably no harm in `LegacyMd5Plugin.create()` automatically if WHEN_REQUIRED is configured, but we could also introduce a property for it. @[email protected] do you have any opinions? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I9443c9327a6bedb7e39c2ef1b729962b2237a974 Gerrit-Change-Number: 21277 Gerrit-PatchSet: 6 Gerrit-Owner: Preetham Poluparthi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Hussain Altowileb <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Hussain Altowileb <[email protected]> Gerrit-Attention: Preetham Poluparthi <[email protected]> Gerrit-Comment-Date: Tue, 26 May 2026 11:54:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
