>From Michael Blow <[email protected]>: Attention is currently required from: Ritik Raj.
Michael Blow has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21291?usp=email ) Change subject: [ASTERIXDB-3768][CLOUD] Set explicit CRC32C checksum on S3 DeleteObjects ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3CloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21291/comment/139a8b9d_34217d77?usp=email : PS1, Line 285: DeleteObjectsRequest.Builder deleteReqBuilder = : DeleteObjectsRequest.builder().bucket(bucket).delete(delete); : if (config.getChecksumBehavior() == S3ChecksumBehavior.WHEN_REQUIRED) { : // DeleteObjects needs a request-body integrity header; when_required suppresses the SDK's flexible : // checksum and it no longer adds Content-MD5, so request an explicit checksum for S3-compatible stores : // https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteObjects.html : deleteReqBuilder.checksumAlgorithm(ChecksumAlgorithm.CRC32_C); : } : DeleteObjectsResponse deleteObjectsResponse = s3Client.deleteObjects(deleteReqBuilder.build()); I would prefer this behavior be optionally controlled by a `CloudProperties` flag, but we can do that in the future in a backwards-compatible way (e.g. a `CLOUD_STORAGE_S3_DELETE_OBJECTS_INCLUDE_CRC32_CHECKSUM` can default to checksum `behavior == WHEN_REQUIRED` or similar) -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21291?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I49f6c6f1c44243f7e69f1ec55d5534a14019dcdf Gerrit-Change-Number: 21291 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2026 12:35:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
