>From Calvin Thomas Dani <[email protected]>: Attention is currently required from: Ali Alsuliman, Ian Maxon.
Calvin Thomas Dani has posted comments on this change by Calvin Thomas Dani. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126?usp=email ) Change subject: [ASTERIXDB-3676] Vector Distance Functions ...................................................................... Patch Set 25: (4 comments) File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/vector/VectorDistanceArrScalarEvaluator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/83be84c8_84d367ad?usp=email : PS19, Line 160: PointableHelper.setNull(result); > +1 to this comment Acknowledged https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/25e03db4_4c022d53?usp=email : PS19, Line 194: AMutableDouble aDouble = new AMutableDouble(-1); > this doesn't seem to be applied Applied https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/362354b2_8e38830b?usp=email : PS19, Line 212: extractNumericVector > this is a good edit- i would take it Acknowledged and added File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/VectorDistanceArrCalculation.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/bffa4941_3764c8d5?usp=email : PS22, Line 33: if (a.length != b.length) { : throw new IllegalArgumentException("Vectors must be of the same length"); : } > doing the length check here is probably not the right way to go about it. the > caller should check. […] Acknowledged -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I45176e7da13ed222f48bb36bd1f0ab4074a0bcb9 Gerrit-Change-Number: 20126 Gerrit-PatchSet: 25 Gerrit-Owner: Calvin Thomas Dani <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2026 21:44:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Calvin Thomas Dani <[email protected]> Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Ali Alsuliman <[email protected]>
