>From Rithwik Koul <[email protected]>:
Attention is currently required from: Ali Alsuliman, Preetham Poluparthi,
Rithwik Koul.
Hello Ali Alsuliman, Ali Alsuliman, Anon. E. Moose #1000171, Jenkins, Preetham
Poluparthi,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21290?usp=email
to look at the new patch set (#15).
The following approvals got outdated and were removed:
Contrib-2 by Anon. E. Moose #1000171, Verified-1 by Jenkins
Change subject: [ASTERIXDB-3778][COMP] Drop constant ORDER BY sort keys
......................................................................
[ASTERIXDB-3778][COMP] Drop constant ORDER BY sort keys
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Adds RemoveConstantOrderByExpressionsRule, which strips entries from
OrderOperator.getOrderExpressions() whose value is a compile-time
constant. The OrderOperator is unwrapped entirely if every key
becomes constant.
Ext-ref: MB-72146
Change-Id: I1156355d55b0f4cdde0044fb94e9c1b3ed15a3f2
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveConstantOrderByExpressionsRule.java
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/group-by/grouping-sets-empty-branch.sqlpp
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/group-by/grouping-sets-rollup-shape.sqlpp
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/order-by/order-by-real-var.sqlpp
M
asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate-sql-sugar/distinct_mixed/distinct_mixed.17.plan
M
asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate-subclause/agg_filter_01/agg_filter_01.5.plan
M
asterixdb/asterix-app/src/test/resources/optimizerts/results/group-by/grouping-sets-1.2.plan
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/group-by/grouping-sets-empty-branch.plan
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/group-by/grouping-sets-rollup-shape.plan
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/order-by/order-by-real-var.plan
11 files changed, 822 insertions(+), 356 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/90/21290/15
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21290?usp=email
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: lumina
Gerrit-Change-Id: I1156355d55b0f4cdde0044fb94e9c1b3ed15a3f2
Gerrit-Change-Number: 21290
Gerrit-PatchSet: 15
Gerrit-Owner: Rithwik Koul <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Preetham Poluparthi <[email protected]>
Gerrit-Reviewer: Rithwik Koul <[email protected]>
Gerrit-CC: Murtadha Hubail <[email protected]>
Gerrit-Attention: Rithwik Koul <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Preetham Poluparthi <[email protected]>
