>From Ali Alsuliman <[email protected]>: Ali Alsuliman has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21309?usp=email )
Change subject: [ASTERIXDB-3559][COMP] Fix incorrect 0.0 cost annotation for GROUP BY and ORDER BY operators ...................................................................... [ASTERIXDB-3559][COMP] Fix incorrect 0.0 cost annotation for GROUP BY and ORDER BY operators - user model changes: no - storage format changes: no - interface changes: no Details: The cost annotation logic could incorrectly assign a cost of zero to GROUP BY and ORDER BY operators, resulting in inaccurate operator cost reporting. Ext-ref: MB-70177 Change-Id: I27c7f3ab2993cbf797547a1a3cf45f2a4c0c9ce2 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21309 Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Ali Alsuliman <[email protected]> --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EstimatedCostComputationVisitor.java M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/cardinality-estimation/join-queries/join-queries.3.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/cardinality-estimation/join-queries/join-queries.4.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/cardinality-estimation/join-queries/join-queries.5.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/cardinality-estimation/join-queries/join-queries.6.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/cardinality-estimation/join-queries/join-queries.7.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/cardinality-estimation/join-queries/join-queries.8.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/cardinality-estimation/single-collection-queries/single-collection-queries.3.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/cardinality-estimation/single-collection-queries/single-collection-queries.4.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/cardinality-estimation/single-collection-queries/single-collection-queries.5.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/cardinality-estimation/single-collection-queries/single-collection-queries.6.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/cardinality-estimation/single-collection-queries/single-collection-queries.7.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.007.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.009.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.011.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.013.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.015.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.017.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.019.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.021.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.023.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.025.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.028.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/not-in_every/not-in_every.101.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/not-in_every/not-in_every.301.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/array-access-pushdown/array-access-pushdown.004.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/array-access-pushdown/array-access-pushdown.006.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/array-access-pushdown/array-access-pushdown.008.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/array-access-pushdown/array-access-pushdown.012.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/field-access-pushdown/field-access-pushdown.004.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/field-access-pushdown/field-access-pushdown.006.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/field-access-pushdown/field-access-pushdown.008.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/field-access-pushdown/field-access-pushdown.010.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/heterogeneous-access-pushdown/heterogeneous-access-pushdown.004.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/join/condition-pushdown/condition-pushdown.012.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/join/condition-pushdown/condition-pushdown.014.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/join/condition-pushdown/condition-pushdown.021.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/join/condition-pushdown/condition-pushdown.023.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/join/condition-pushdown/condition-pushdown.031.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/join/condition-pushdown/condition-pushdown.033.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.006.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.012.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.014.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.020.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.021.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.022.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.024.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.026.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/same-datasource-diff-scan/same-datasource-diff-scan.004.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/same-datasource-diff-scan/same-datasource-diff-scan.005.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/same-datasource-diff-scan/same-datasource-diff-scan.006.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/same-datasource-diff-scan/same-datasource-diff-scan.007.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/correlation/ASTERIXDB-3752-LIMIT-in-subquery/ASTERIXDB-3752-LIMIT-in-subquery.4.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-only-testcases/simple-index-only/simple-index-only.10.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-only-testcases/simple-index-only/simple-index-only.11.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-only-testcases/simple-index-only/simple-index-only.6.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-only-testcases/simple-index-only/simple-index-only.7.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-only-testcases/simple-index-only/simple-index-only.8.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-only-testcases/simple-index-only/simple-index-only.9.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-selection/btree-index-array-range/btree-index-array-range.04.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-selection/btree-index-array-range/btree-index-array-range.06.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-selection/btree-index-array-range/btree-index-array-range.08.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-selection/btree-index-range-02/btree-index-range-02.04.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-selection/btree-index-range-02/btree-index-range-02.06.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-selection/btree-index-range-02/btree-index-range-02.13.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-selection/btree-index-range/btree-index-range.06.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-selection/duplicate-predicate-index/duplicate-predicate-index.4.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/index-selection/duplicate-predicate-index/duplicate-predicate-index.5.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/join/hash-join-with-redundant-variable/hash-join-with-redundant-variable.04.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/join/hash-join-with-redundant-variable/hash-join-with-redundant-variable.06.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/join/hash-join-with-redundant-variable/hash-join-with-redundant-variable.08.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/join/hash-join-with-redundant-variable/hash-join-with-redundant-variable.10.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/join/hash-join-with-redundant-variable/hash-join-with-redundant-variable.12.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/join/hash-join-with-redundant-variable/hash-join-with-redundant-variable.14.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/join/hash-join-with-redundant-variable/hash-join-with-redundant-variable.16.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/leftouterjoin/index-only-leftouterjoin/index-only-leftouterjoin.007.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/leftouterjoin/index-only-leftouterjoin/index-only-leftouterjoin.008.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/leftouterjoin/index-only-leftouterjoin/index-only-leftouterjoin.009.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/leftouterjoin/index-only-leftouterjoin/index-only-leftouterjoin.010.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/limit/offset_without_limit/offset_without_limit.6.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/limit/push-limit-to-primary-scan/push-limit-to-primary-scan.8.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/objects/load-record-fields/load-record-fields.4.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/objects/load-record-fields/load-record-fields.6.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/tpch/query-plans/query-plans.03.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/tpch/query-plans/query-plans.05.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/tpch/query-plans/query-plans.06.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/tpch/query-plans/query-plans.07.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/tpch/query-plans/query-plans.08.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/tpch/query-plans/query-plans.09.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/tpch/query-plans/query-plans.11.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/view/view-pushdown/view-pushdown.08.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/view/view-pushdown/view-pushdown.10.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/view/view-pushdown/view-pushdown.12.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/view/view-pushdown/view-pushdown.14.plan 94 files changed, 1,122 insertions(+), 1,119 deletions(-) Approvals: Ali Alsuliman: Looks good to me, approved Jenkins: Verified; Verified -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21309?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I27c7f3ab2993cbf797547a1a3cf45f2a4c0c9ce2 Gerrit-Change-Number: 21309 Gerrit-PatchSet: 5 Gerrit-Owner: Preetham Poluparthi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]>
