>From Michael Blow <[email protected]>: Attention is currently required from: Ali Alsuliman, Hussain Towaileb, Murtadha Hubail.
Michael Blow has posted comments on this change by Ali Alsuliman. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21315?usp=email ) Change subject: [NO ISSUE][OTH] Ignore directory objects returned for listing objects from S3 ...................................................................... Patch Set 1: (1 comment) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21315/comment/faebb09d_6eaa9335?usp=email : PS1, Line 56: object -> !object.key().endsWith("/") can we add a helper in S3Utils e.g. isDirectory(S3Object) and then we can just use `Predicate.not(S3Utils:: isDirectory)` and use that isDirectory both places? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21315?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I1a34f22e250403f3b93e7fe1291bd50b97c00ed8 Gerrit-Change-Number: 21315 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-CC: Jenkins <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Fri, 05 Jun 2026 14:01:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
