>From Ali Alsuliman <[email protected]>:
Attention is currently required from: Ali Alsuliman, Hussain Towaileb, Murtadha
Hubail.
Hello Hussain Towaileb, Michael Blow, Murtadha Hubail,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21315?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Ali Alsuliman
Change subject: [NO ISSUE][OTH] Ignore directory objects returned for listing
objects from S3
......................................................................
[NO ISSUE][OTH] Ignore directory objects returned for listing objects from S3
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
Some S3-storage implementations return directory objects
in addition to the real objects when listing objects from a bucket.
This causes a failure since we don’t expect such objects to exist.
Directory objects are the ones created with a training
slash / and 0-byte size. We should filter out the objects
ending with / since we don’t create such objects.
Ext-ref: MB-72272
Change-Id: I1a34f22e250403f3b93e7fe1291bd50b97c00ed8
---
M
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientUtils.java
M
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ParallelDownloader.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java
3 files changed, 15 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/15/21315/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21315?usp=email
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: lumina
Gerrit-Change-Id: I1a34f22e250403f3b93e7fe1291bd50b97c00ed8
Gerrit-Change-Number: 21315
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-CC: Jenkins <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Hussain Towaileb <[email protected]>
