>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb.
Michael Blow has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21351?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: [NO ISSUE][EXT]: allow custom iceberg catalog endpoint in tests ...................................................................... Patch Set 4: -Code-Review (2 comments) File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestConstants.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21351/comment/d934f532_965e26e7?usp=email : PS4, Line 39: public static final String S3_SERVICE_ENDPOINT_DOCKER_PLACEHOLDER = "%serviceEndpointDocker%"; : public static String S3_SERVICE_ENDPOINT_DOCKER; I don't understand why we need this- a subclass of TestExecutor can override `getS3ServiceEndpointDefault()` to return a dynamic value. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21351/comment/b0697ae0_1e3eb324?usp=email : PS4, Line 115: public static String NESSIE_URI; We should treat this the same as `S3_SERVICE_ENDPOINT_DEFAULT`, have a static final default that can be overridden as needed. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21351?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I8667ce486c480757784046b77747a9b9f756026b Gerrit-Change-Number: 21351 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Fri, 19 Jun 2026 21:26:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
