>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb.
Michael Blow has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21351?usp=email ) Change subject: [NO ISSUE][EXT]: allow custom iceberg catalog endpoint in tests ...................................................................... Patch Set 7: Code-Review+2 (1 comment) File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/iceberg/IcebergTest.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21351/comment/cc255af9_f45c95a7?usp=email : PS7, Line 132: private static final int NESSIE_PORT = 19120; : private static final String NESSIE_URI = "http://localhost:"; + NESSIE_PORT + "/api/v2"; I guess both of these could've been defined in TestConstants, then you could just return NESSIE_URI in `TestExecutor.getNessieEndpointDefault()`, but it's fine this way. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21351?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I8667ce486c480757784046b77747a9b9f756026b Gerrit-Change-Number: 21351 Gerrit-PatchSet: 7 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Sat, 20 Jun 2026 22:22:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
