>From Hongyu Shi <[email protected]>: Attention is currently required from: Ian Maxon.
Hongyu Shi has posted comments on this change by Hongyu Shi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21099?usp=email ) Change subject: [ASTERIXDB-3754] Storage layer of VTree index - patch 1 ...................................................................... Patch Set 10: (10 comments) File hyracks-fullstack/hyracks/hyracks-storage-am-vtree/src/main/java/org/apache/hyracks/storage/am/vector/api/IVTreeDataFrame.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21099/comment/fff40f22_4800e8b1?usp=email : PS2, Line 67: void split(VTreeDataFrame rightFrame, ITupleReference tuple, int insertIndex) throws HyracksDataException; : : int findInsertPosition(double distance) throws HyracksDataException; > javadoc might be nice for these added in VTreeDataFrame File hyracks-fullstack/hyracks/hyracks-storage-am-vtree/src/main/java/org/apache/hyracks/storage/am/vector/api/IVTreeDistanceFunction.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21099/comment/dc377c27_9ca43c5b?usp=email : PS2, Line 25: from AsterixDB to Hyracks modules > ```suggestion […] Done File hyracks-fullstack/hyracks/hyracks-storage-am-vtree/src/main/java/org/apache/hyracks/storage/am/vector/api/IVTreeInteriorFrame.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21099/comment/383b88fe_b755e297?usp=email : PS2, Line 74: void setOverflowFlagBit(boolean overflowFlag); : : boolean getOverflowFlagBit(); > how's the overflow stuff work again? can't remember Interior/Leaf cluster could have overflow pages to accommodate all centroids. File hyracks-fullstack/hyracks/hyracks-storage-am-vtree/src/main/java/org/apache/hyracks/storage/am/vector/frames/VTreeDataFrameFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21099/comment/58029caa_e975d8bd?usp=email : PS2, Line 28: cosine > it's not necessarily cosine, is it? Done File hyracks-fullstack/hyracks/hyracks-storage-am-vtree/src/main/java/org/apache/hyracks/storage/am/vector/frames/VTreeMetadataFrame.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21099/comment/626421e2_23381add?usp=email : PS2, Line 73: // Binary search for the appropriate metadata entry : for (int i = 0; i < tupleCount; i++) { : frameTuple.resetByTupleIndex(this, i); : double maxDistance = getMaxDistance(i); : : if (distance <= maxDistance) { : return getDataPagePointer(i); : } : } : > unless i'm missing something, this isn't binary search? Done File hyracks-fullstack/hyracks/hyracks-storage-am-vtree/src/main/java/org/apache/hyracks/storage/am/vector/impls/VTreeBulkLoader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21099/comment/dabb45c7_74c775f5?usp=email : PS2, Line 463: TreeMap<Integer, ICachedPage> staticPages = new TreeMap<>(); > how many pages is the static structure usually again? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21099/comment/1ffba91a_a5306243?usp=email : PS2, Line 468: ICachedPage page = bufferCache.confiscatePage(dpid); > there's no way to confiscate only 1 or 2 pages at a time? you have to > confiscate the entire structur […] Done File hyracks-fullstack/hyracks/hyracks-storage-am-vtree/src/main/java/org/apache/hyracks/storage/am/vector/impls/VTreeFlushLoader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21099/comment/72c9aad8_8b668082?usp=email : PS2, Line 142: ICachedPage page = bufferCache.confiscatePage(dpid); > again here about confiscating the entire structure versus some fixed number > of pages at a time Done File hyracks-fullstack/hyracks/hyracks-storage-am-vtree/src/main/java/org/apache/hyracks/storage/am/vector/impls/VTreeStaticStructureBuilder.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21099/comment/054bc646_b9d0ba3b?usp=email : PS2, Line 475: /** : * Only gets called when everything is done. : */ > nit: comments are fine but i don't care much for obvious ones like this Done File hyracks-fullstack/hyracks/hyracks-storage-am-vtree/src/main/java/org/apache/hyracks/storage/am/vector/utils/VectorDistanceUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21099/comment/61413bb2_41f04852?usp=email : PS2, Line 29: DistanceMetric > how does this work with the interface that lets you specify the vector > distance function from the ap […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21099?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Id613553fb11bf97ca9c75ae843dee470acc36b5d Gerrit-Change-Number: 21099 Gerrit-PatchSet: 10 Gerrit-Owner: Hongyu Shi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Wed, 01 Jul 2026 21:50:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]>
