>From Ian Maxon <[email protected]>: Attention is currently required from: Murtadha Hubail, Ritik Raj.
Ian Maxon has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21372?usp=email ) Change subject: [ASTERIXDB-3788][STO] flush .dic LAF pages in ascending page-id order ...................................................................... Patch Set 3: (6 comments) Patchset: PS3: was claude not used at all for this? the comments are wordy and remind me of opus's usual writing style File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/cloud_storage/CloudStorageMergeTest.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21372/comment/6dc417a3_f9dcf9d0?usp=email : PS3, Line 56: MB-72604 ```suggestion * Cloud-deployment regression test for ASTERIXDB-3788: a large columnar MERGE must flush the ``` File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/compression/file/LAFWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21372/comment/06843d39_f0977a77?usp=email : PS3, Line 52: MB-72604 refer to the apache issue instead? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21372/comment/03e7a51f_98b9635d?usp=email : PS3, Line 153: MB-72604 same here https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21372/comment/dc7bcaba_3c41365e?usp=email : PS3, Line 186: flushReadyPages(); is there any realistic way that say, a page early in the file could remain underfull and lead to some kind of starvation scenario from confiscation? since this has been misbehaving w.r.t append only for a long time apparently https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21372/comment/ab2277f3_7c0c0d57?usp=email : PS3, Line 215: The local file is : * random-access and indifferent to order; only the cloud copy needs this guarantee. i don't follow this comment. isn't this method basically flushing the pages that are full sequentially? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21372?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I2a8a83cd1b57d3ceb1d9be381edd6589a0e138b9 Gerrit-Change-Number: 21372 Gerrit-PatchSet: 3 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Thu, 02 Jul 2026 16:56:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
