>From Hongyu Shi <[email protected]>: Attention is currently required from: Ian Maxon.
Hongyu Shi has posted comments on this change by Hongyu Shi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21100?usp=email ) Change subject: [ASTERIXDB-3754] Storage layer of VTree index - patch 2 ...................................................................... Patch Set 15: (2 comments) File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-vtree/src/main/java/org/apache/hyracks/storage/am/lsm/vector/dataflow/VectorSearchOperatorNodePushable.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21100/comment/6b9fb1c0_f85a46d8?usp=email : PS5, Line 107: // Note: > this comment block is kind of confusing from the Note: prefix on each line Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-vtree/src/main/java/org/apache/hyracks/storage/am/lsm/vector/impls/LSMVTreeDiskComponent.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21100/comment/b4a512be_3fb019ed?usp=email : PS5, Line 156: numLevels = (Integer) parameters.getOrDefault("numLevels", 2); : @SuppressWarnings("unchecked") : List<Integer> clustersPerLevel = : (List<Integer>) parameters.getOrDefault("clustersPerLevel", Arrays.asList(5, 10)); > would it be expected to somehow get a null parameter here normally? i worry > about what might happen […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21100?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I87c468c14cbeb3e698742429ee62df02c8e83efe Gerrit-Change-Number: 21100 Gerrit-PatchSet: 15 Gerrit-Owner: Hongyu Shi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Thu, 02 Jul 2026 20:13:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]>
