>From Ritik Raj <[email protected]>: Attention is currently required from: Ian Maxon.
Ritik Raj has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20959?usp=email ) Change subject: [ASTERIXDB-3702][RT][STO] LSM Sampling ...................................................................... Patch Set 14: (6 comments) File hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/data/normalizers/Integer8NormalizedKeyComputerFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20959/comment/61345686_3c7370d8?usp=email : PS7, Line 48: normalizedKeys[keyStart] = value ^ 0x80; > should this be left-shifted? and won't the xor act weird because it's in an > int and not a byte? Done File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BatchPredicateWithKeys.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20959/comment/be8ae797_cb1251b1?usp=email : PS7, Line 28: /** : * : */ > nit: remove Done File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/DiskBTree.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20959/comment/c317d9a6_23527da8?usp=email : PS7, Line 204: enumerateLeafPageIds( > this sort of makes sense but what if the component is giant? won't this array > grow to be like ~125MB […] yeah, interesting point. I missed these, looking into how to compress these, trying to run few micro benchmark if this can be encoded like using bitmap while storing, there are few algorithms, checking those. Will update. Thanks for pointing this out. File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/DiskBTreeSampleCursor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20959/comment/269de9fd_0a9d4e30?usp=email : PS7, Line 99: private long totalTimeTakenToFindRandomLeaf = 0; : private long totalTimeTakenToFindRandomTuples = 0; : private long totalLeafDrawBatches = 0; : private long totalLeafDraws = 0; : private long totalLeafDrawUniquePages = 0; : private long totalLeafPins = 0; : private long totalReusedPinnedPageHits = 0; : private boolean endedPreemptively = false; : > might be cool to propagate these up somehow to the operator and make it a > self-profiling operator so […] Ack, will raise another patch to address this. File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/dataflow/BTreeSampleCollectorOperatorDescriptorNodePushable.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20959/comment/17126818_74c3d57f?usp=email : PS7, Line 111: stats.getInputTupleCounter().update(matchingTupleCount); > shouldn't this be outside the loop? Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/theta/ThetaSampler.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20959/comment/4dba8cfe_0da86f3d?usp=email : PS7, Line 194: temp[i] = heap.dequeueLong(); > can there be some switch that stops you from accidentally reusing an instance > of this object after t […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20959?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: If5c5b7eac5199b85fc40b722c87ae0bbb73eecbd Gerrit-Change-Number: 20959 Gerrit-PatchSet: 14 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2026 09:51:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]>
