Michael Blow has submitted this change and it was merged. Change subject: Fix NPE in DatasetDirectoryService.reportJobFailure ......................................................................
Fix NPE in DatasetDirectoryService.reportJobFailure Change-Id: I4c27d2133d199bbb6984f8da14e37b2e511528ac Reviewed-on: https://asterix-gerrit.ics.uci.edu/1582 Reviewed-by: abdullah alamoudi <[email protected]> Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> BAD: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: abdullah alamoudi: Looks good to me, approved Jenkins: Verified; No violations found; No violations found; Verified diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java index 927d499..8fd15f9 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java @@ -159,9 +159,10 @@ if (djr != null) { djr.fail(exceptions); } - // TODO(tillw) throwing an NPE here hangs the system, why? - // TODO(tillw) still run into NPE here .. - jobResultLocations.get(jobId).setException(exceptions.isEmpty() ? null : exceptions.get(0)); + final JobResultInfo jobResultInfo = jobResultLocations.get(jobId); + if (jobResultInfo != null) { + jobResultInfo.setException(exceptions.isEmpty() ? null : exceptions.get(0)); + } notifyAll(); } -- To view, visit https://asterix-gerrit.ics.uci.edu/1582 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c27d2133d199bbb6984f8da14e37b2e511528ac Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]>
