Yingyi Bu has posted comments on this change. Change subject: Index-only plan step 3: Top-down Select and Join transformation rule ......................................................................
Patch Set 4: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1551/4/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java: PS4, Line 75: NO_INDEX_FIELD_NAME_FOR_GIVEN_FUNC_EXPR Move those error code to the ErrorCode class in AsterixDB since hyracks doesn't have concept of datasets etc. AsterixException is a subclass of AlgebricksException so type-wise, it should be fine. https://asterix-gerrit.ics.uci.edu/#/c/1551/4/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties File hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties: PS4, Line 62: s move the error code to AsterixDB? -- To view, visit https://asterix-gerrit.ics.uci.edu/1551 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60a2a61eb46851d4c16c8f17447e3ac9b0aca778 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
