>From Janhavi Tripurwar <[email protected]>: Attention is currently required from: Ali Alsuliman, Michael Blow, Murtadha Hubail.
Janhavi Tripurwar has posted comments on this change by Janhavi Tripurwar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21619?usp=email ) Change subject: [ASTERIXDB-3593]Fix multi-statement response indentation ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/NcStatementsPrinter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21619/comment/fffe1624_0623d758?usp=email : PS1, Line 197: PrintWriter rows = new PrintWriter(new TrailingNewlineHolder(pw)); > I didn't get what this `TrailingNewlineHolder` does. Let's talk about it. ResultPrinter ends the results array with println(" ]"), so it always adds a newline at the end. That newline landed before the , separator, so results and status looked disconnected: "results": [ { "a": 1 } ] , "status": "success" It is not needed. Claude could get the same result by overriding println on the PrintWriter we pass in, so it just calls print instead: PrintWriter rows = new PrintWriter(pw) { @Override public void println(String x) { print(x); } }; -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21619?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2cc80e82b2f93fc2feab1c0ba4491773e12414b6 Gerrit-Change-Number: 21619 Gerrit-PatchSet: 2 Gerrit-Owner: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Thu, 27 Aug 2026 17:46:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]>
