>From Janhavi Tripurwar <[email protected]>:

Attention is currently required from: Ali Alsuliman, Michael Blow, Murtadha 
Hubail.

Janhavi Tripurwar has posted comments on this change by Janhavi Tripurwar. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21576?usp=email )

Change subject: [ASTERIXDB-3593][API] Track every job of a multi-statement 
request
......................................................................


Patch Set 9: Code-Review+1

(3 comments)

File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/ClientRequest.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21576/comment/94465e1f_f5bb5f51?usp=email
 :
PS5, Line 84:     public void setPlan(String plan) {
> We need to adapt this for multi-statements.
Done


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21576/comment/ccca4ef8_75798fb3?usp=email
 :
PS5, Line 151:         // if the request has jobs, we abort all of them and do 
not interrupt the thread as it will be
> Don't we need to exclude the jobs that have already run and reached a 
> terminal state (e.g. […]
Fixed.


File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ClientInfoRequestMessage.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21576/comment/596f7cd0_dc7e8c20?usp=email
 :
PS5, Line 68:                         clientRequest.getCompileTimeNanos(), 
clientRequest.getElapsedTimeMillis(), run.getCreateTime(),
> We need to take a look at these and see whether they are request-specific or 
> job-specific.
requestTime and elapsedTime are request-level, they stay at request level and 
aren't repeated per job.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21576?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I34debfac471df71034b9b29c0cc84a9dd7acac78
Gerrit-Change-Number: 21576
Gerrit-PatchSet: 9
Gerrit-Owner: Janhavi Tripurwar <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Janhavi Tripurwar <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Comment-Date: Tue, 01 Sep 2026 14:55:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ali Alsuliman <[email protected]>

Reply via email to