>From Ian Maxon <[email protected]>: Attention is currently required from: Ali Alsuliman, Michael Blow, Murtadha Hubail, Ritik Raj.
Ian Maxon has posted comments on this change by Michael Blow. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627?usp=email ) Change subject: [NO ISSUE][STO] Reclaim idle memory components when the vbc is full ...................................................................... Patch Set 2: (3 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627/comment/aae0cf9f_513d8cb9?usp=email : PS2, Line 7: NO ISSUE] this seems like a substantial enough change to merit an issue, because it is changing longstanding code which seems to have a problem. it's not just fixing some typo or etc. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627/comment/cd1855dd_28fc088f?usp=email : PS2, Line 46: Change-Id: I4cccd9857d277b1a32017f0afcbd644e33388f2f should be the last line shouldn't it? though i guess it worked File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/GlobalVirtualBufferCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627/comment/52536c22_4a6ca26e?usp=email : PS2, Line 518: * behind for data that never arrived, and enough such indexes fill the cache with components that : * {@link #selectFlushIndex()} will never select, because it only selects components which are not empty. if this is the specific situation this method fixes, why not instead make it so that selectFlushIndex() instead considers empty components as well (obviously at the lowest priority)? wouldn't that be simpler? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21627?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: totoro Gerrit-Change-Id: I4cccd9857d277b1a32017f0afcbd644e33388f2f Gerrit-Change-Number: 21627 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Tue, 01 Sep 2026 17:06:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
